[coreboot-gerrit] Change in coreboot[master]: cbfstool: Fix offset calculation for aligned files

[Patrick Georgi (Code Review)]

Attention is currently required from: Raul Rangel, Julius Werner, Tim Wawrzynczak.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59877 )

Change subject: cbfstool: Fix offset calculation for aligned files
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

Patchset:

PS2: 
Thanks, it's already much clearer in the end, even with the stated remaining deficiencies.

My main proposal would have been to split it up in smaller commits to ease review (e.g. moving the type argument to param.type, the if(A) {if(B) {...}} -> if(A && B) {...} change once the other part in if(A) is gone).

OTOH I'm through now and if others don't see an issue with that during review, I'm not sure you need to bother.

I'd give this +2, but I'd also appreciate a second opinion, so waiting for another day or two before upgrading my review score.