Attention is currently required from: Shelley Chen, Taniya Das, Paul Menzel, Sudheer Amrabadi.
Venkat Thogaru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs ......................................................................
Patch Set 11:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68384/comment/4ad4cbc9_3cd6219e PS9, Line 7:
Please use one space.
Done
https://review.coreboot.org/c/coreboot/+/68384/comment/566a11ce_a25e6508 PS9, Line 7: Add socinfo_pro_part() function in : coreboot
Maybe: Add function to differentiate between PRO and NON_PRO SKUs
Done
https://review.coreboot.org/c/coreboot/+/68384/comment/ab35e357_75b646b5 PS9, Line 8: coreboot
Please just use one line for the summary [1]. […]
Done
https://review.coreboot.org/c/coreboot/+/68384/comment/a339731d_c67fdcf4 PS9, Line 10:
Please use exactly one space.
Done
https://review.coreboot.org/c/coreboot/+/68384/comment/6db0aeed_ce6445a2 PS9, Line 10: The API socinfo_pro_part is added to help to differentiate : between PRO and NON_PRO SKUs. Returns 1 for Pro : and 0 for NON_PRO SKUs.
Please reflow for 72 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/68384/comment/6313a331_131f5337 PS9, Line 15: Validate boards are detected correctly on PRO : and NON_PRO SKUs
Ditto.
Done
Patchset:
PS9:
The commit seems to do more changes than documented in the commit message.
Done