Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34447 )
Change subject: soc/intel/common: Set controller state to active in uart init ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 36: struct device *dev can u make this as first argument ?
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 39: tab here
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 87: uart_lpss_init(baseaddr,device); one space here
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 230: uart_lpss_init(base,dev); one space here