[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Move sd_emmc_config into emmc_config struct

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45095 )

Change subject: soc/amd/picasso: Move sd_emmc_config into emmc_config struct
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45095/1/src/soc/amd/picasso/fsp_par... 
File src/soc/amd/picasso/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/45095/1/src/soc/amd/picasso/fsp_par... 
PS1, Line 17: SD_DISABLE
Outside the scope of this patch but it looks like we should move these definitions from soc/ to vc//platform_descriptors.h.  Also FWIW I don't see much point in translating an enum value to an identical #define value but maybe I'm overlooking something.