Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45860 )
Change subject: mb/google/volteer/variants/eldrid: disable Fan Performance Control and Passive Policy ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45860/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45860/5/src/mainboard/google/voltee... PS5, Line 62: Default DPTF Policy for all Volteer boards if not overridden
Should be "DPTF Policy for Eldrid board", or you can remove this comment completely.
Done
https://review.coreboot.org/c/coreboot/+/45860/5/src/mainboard/google/voltee... PS5, Line 67: TEMP_PCT(85, 90), : TEMP_PCT(80, 69), : TEMP_PCT(75, 56), : TEMP_PCT(70, 46), : TEMP_PCT(65, 36),}},
nit: line these up
Done
https://review.coreboot.org/c/coreboot/+/45860/5/src/mainboard/google/voltee... PS5, Line 73: TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}}
same
Done
https://review.coreboot.org/c/coreboot/+/45860/5/src/mainboard/google/voltee... PS5, Line 79: TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}}
same
Done
https://review.coreboot.org/c/coreboot/+/45860/5/src/mainboard/google/voltee... PS5, Line 85: TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}},
same
Done
https://review.coreboot.org/c/coreboot/+/45860/5/src/mainboard/google/voltee... PS5, Line 91: TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}}}
same
Done