Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Split I2c implementation for psp_verstage
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86...
File src/soc/amd/picasso/i2c-x86.c:
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86...
PS5, Line 11: i2c_bus_address[]
i2c_bus_address[I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT]
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86...
PS5, Line 19: _Static_assert(
: ARRAY_SIZE(i2c_bus_address) == I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT,
: "ARRAY_SIZE(i2c_bus_address) must equal I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT");
remove
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45380e0c61e1bb7a94a96630e5867b7ffca0909c
Gerrit-Change-Number: 42064
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 20:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment