Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35103 )
Change subject: [WIP] mb/intel/cannonlake_rvp,coffeelake_rvp: Add LPC_TPM
......................................................................
Patch Set 1:
(1 comment)
I am waiting for Subrata to tell if these boards have LPC signals routed such that LPC_TPM would ever be possible. Error might be in devicetree.cb instead.
https://review.coreboot.org/c/coreboot/+/35103/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35103/1//COMMIT_MSG@9
PS1, Line 9: 7
should be a slash instead
oh shift!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia959ae9072e3fc709b779b1fc778eb82e10c2ee3
Gerrit-Change-Number: 35103
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 17:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment