[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Change TPM interface from SPI to I2C

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30978 )

Change subject: google/kukui: Change TPM interface from SPI to I2C
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30978/2/src/mainboard/google/kukui/verstage.... 
File src/mainboard/google/kukui/verstage.c:

https://review.coreboot.org/#/c/30978/2/src/mainboard/google/kukui/verstage.... 
PS2, Line 26: if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KUKUI) && board_id() < 2) {
            : 		die("This board is no longer supported. "
            : 		    "Please use older AP firmware.\n");
            : 	}
Seems like talking to EC may have some problem here in verstage.

We should check if P1 units can still enter rom stage without this assertion. If yes, then this can be moved to romstage or even later.