Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31606 )
Change subject: libpayload: cbfs: Require input size and output size for cbfs_decompress ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/include/cbfs_cor... File payloads/libpayload/include/cbfs_core.h:
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/include/cbfs_cor... PS1, Line 257: int srcn These should be changed to size_t while we're here.
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/libcbfs/cbfs_cor... File payloads/libpayload/libcbfs/cbfs_core.c:
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/libcbfs/cbfs_cor... PS1, Line 331: len = MIN(srcn, dstn); nit: Maybe just
assert(srcn <= dstn); memcpy(dst, src, srcn);
?