[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variant/atlas: enable USB acpi

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30754 )

Change subject: mb/google/poppy/variant/atlas: enable USB acpi
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30754/1/src/mainboard/google/poppy/variants/... 
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:

https://review.coreboot.org/#/c/30754/1/src/mainboard/google/poppy/variants/... 
PS1, Line 284: reset_gpio
> The reset here is a specific hack for intel bluetooth: https://patchwork.kernel. […]

GPP_E2 goes to the device's W_DISABLE2# pin which completely shuts
down bluetooth - it's not really a classic reset pin.
i was contemplating leaving this off (asserted) in coreboot until
something higher up decides to enable bluetooth.

i don't see the timing requirements for this signal in the EPS.
the driver duncan mentioned does a 100ms blip.