Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48223 )
Change subject: mb/google/volteer: ACPI nodes for volteer2_ti50 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee... PS3, Line 205: GOOG0005
Good point. I had missed that the HID used was different than other I2C cr50 devices.
Its actually the same as current H1 I2C, but we could make it different.
I don't know that we need it to be different, but there were some odd architectural limitations we found when I first did the H1 I2C drivers that we might be able to improve with Ti50. (maybe? I have not looked into it yet..)
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee... PS3, Line 207: off
I didn't suggest that because it takes away another bit from FW_CONFIG space for all variants.
Ya we are down to ~15 free bits in the program fw_config, but we also have this unused 4-bit field for "thermal" which could be repurposed.
Since this is a non-shipping config it is probably fine as is..