Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30855 )
Change subject: arch/x86: Align _start16bit with C_ENVIRONMENT_BOOBLOCK ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30855/2/src/cpu/x86/16bit/entry16.inc File src/cpu/x86/16bit/entry16.inc:
https://review.coreboot.org/#/c/30855/2/src/cpu/x86/16bit/entry16.inc@32 PS2, Line 32: #if IS_ENABLED(CONFIG_C_ENVIRONMENT_BOOTBLOCK) || \
Presumably this works because _start16bit is < 2^11 away from reset vector? This symbol needs to be […]
Where does this 2^11 come from? 2^16 ? cpu/x86/16bit/reset.ld claims 4 GiB - 64KiB is acceptable, with an assert. I agree, increasing C_ENV_BOOTBLOCK_SIZE beyond 64 KiB would make this fail.
At the moment _start16bit is at the very beginning of bootblock, probably due the include order, at 4 GiB - C_ENV_BOOTBLOCK_SIZE.