Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56052 )
Change subject: WIP: soc/amd/common/block/lpc: Don't disable the HOG bit ......................................................................
WIP: soc/amd/common/block/lpc: Don't disable the HOG bit
This bit breaks SPI DMA.
BUG=b:179699789 TEST=Boot guybrush and see SPI DMA working
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: If015869657f36d3533f4ab9ebd1f54b0d4eb283b --- M src/soc/amd/common/block/lpc/lpc.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/56052/1
diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index 2586ba9..6eb5157 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -66,7 +66,7 @@ * on on LPC, it holds PCI grant, so no LPC slave cycle can * interrupt and visit LPC. */ - byte &= ~LPC_NOHOG; + // byte &= ~LPC_NOHOG; pci_write_config8(dev, LPC_MISC_CONTROL_BITS, byte);
/*