Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41189 )
Change subject: payloads: Add gfxtest ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Very nice.
https://review.coreboot.org/c/coreboot/+/41189/1/payloads/gfxtest/gfxtest.c File payloads/gfxtest/gfxtest.c:
https://review.coreboot.org/c/coreboot/+/41189/1/payloads/gfxtest/gfxtest.c@... PS1, Line 8: {0} Spaces around 0? Did you run this through, for example, clang-format?
https://review.coreboot.org/c/coreboot/+/41189/1/payloads/gfxtest/gfxtest.c@... PS1, Line 9: int unsigned int
https://review.coreboot.org/c/coreboot/+/41189/1/payloads/gfxtest/gfxtest.c@... PS1, Line 19: usb_initialize(); Why? I do not see any input handling?