Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46087 )
Change subject: mb/google/volteer/variants/volteer2: Update DPTF parameters
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46087/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46087/4/src/mainboard/google/voltee...
PS4, Line 9:
i think you want 2 tabs here.
https://review.coreboot.org/c/coreboot/+/46087/4/src/mainboard/google/voltee...
PS4, Line 43:
extra blank line?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46087
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a1a0f9e86e519ac15904fac80cf3c2299213e52
Gerrit-Change-Number: 46087
Gerrit-PatchSet: 4
Gerrit-Owner: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-CC: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 08 Oct 2020 02:57:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment