Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47173 )
Change subject: soc/intel/xeon_sp: Don't add memory resource twice
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47173/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47173/2//COMMIT_MSG@7
PS2, Line 7: Don't add memory resource twice
Maybe the commit message can state that with multiple CPUs there are more than one PCI devices with the same VID/DID (that report these resources), but that they will appear on different busses?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia336f604441ae8d30b8418300da7c34ab9907cae
Gerrit-Change-Number: 47173
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 06 Nov 2020 05:45:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment