[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable SD card support for hatch

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30545 )

Change subject: mb/google/hatch: Enable SD card support for hatch
......................................................................

Patch Set 18:

(1 comment)
> Patch Set 18:
>
> (2 comments)

https://review.coreboot.org/#/c/30545/3/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30545/3/src/mainboard/google/hatch/variants/... 
PS3, Line 106: };
> > Yes that was the case earlier, if you take a look at Dragonegg we configure only required GPIOs and let FSP handle others.
>
> Sorry, I had missed out on the reviews for dragonegg, but we should be configuring all GPIOs in coreboot for dragonegg as well.
> > We can push a new patch to configure all the GPIOs.
>
> Why do we need a new patch? Let's just push it as part of this CL.

Yes,for SD card related GPIOs we can do it in this patch. A separate patch, I meant it for any others that we have left out for hatch.