Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36292 )
Change subject: soc/amd: Use common functions to pass UMA information to ramstage ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36292/13/src/soc/amd/common/block/p... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/c/coreboot/+/36292/13/src/soc/amd/common/block/p... PS13, Line 171: static AGESA_STATUS amd_init_post(AMD_POST_PARAMS *PostParams) You may notice that drivers/amd/agesa/state_machine.c passes 'struct sysinfo *cb' here with the intention to pass necessary fields from AMD_POST_PARAMS to top-level romstage_main().
https://review.coreboot.org/c/coreboot/+/36292/13/src/soc/amd/common/block/p... PS13, Line 209: PostParams->MemConfig.UmaSize * 64 * KiB); You could just stash base and size to .bss here, and delay save_uma() call to be done after cbmem_recovery() on normal boot path. But if you have other cases in mind where you need to save romstage information before CBMEM is ready, this is fine I guess.
It might get a bit messy if you need to call save_romstage_info() multiple times.