Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38478 )
Change subject: soc/intel/skylake: Clean up systemagent.asl code
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38478/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38478/1//COMMIT_MSG@11
PS1, Line 11: 2. Update 64 bit SA DRAM bit fields as per SKL EDS.
Well, if it's not a clean-up change, maybe call it "correcting change" instead :P
Hi Paul/Angel,
Thanks for your feedback, i have divided this CL into multiple one, kindly help to review
https://review.coreboot.org/q/topic:%22SKL_Correcting+Change%22+(status:open...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ce4866a83df40c38b69b07a71db3b81bca3981
Gerrit-Change-Number: 38478
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jan 2020 10:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment