16 Dec
2020
16 Dec
'20
8:08 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48461 )
Change subject: src: Replace ENV_PCI_SIMPLE_DEVICE with __SIMPLE_DEVICE__ treewide ......................................................................
Patch Set 2:
Reverts CB:35654 so what's the motivation for the change?
I'm guessing some of the followup changes of removing .c includes breaks without this, did you check for missing <device/pci_ops.h> includes?
--
To view, visit https://review.coreboot.org/c/coreboot/+/48461
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: I6c2c25ce6dc82b8f5bf9d41eb5cecd3b3274d032
Gerrit-Change-Number: 48461
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 16 Dec 2020 08:08:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment