Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45746/6/src/soc/intel/jasperlake/sp...
File src/soc/intel/jasperlake/spd/empty.spd.hex:
PS6:
Rather than using the empty.spd.hex, can we please add placeholder.spd. […]
Done
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl...
File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl...
PS6, Line 5: .spd.hex
I think you don't need the .spd. […]
All of the memory/Makefile.inc for the variants use the full filename of the SPD, including the .hex extension.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45746
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585
Gerrit-Change-Number: 45746
Gerrit-PatchSet: 6
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 22:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment