Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37302 )
Change subject: mb/lenovo/s230u/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... File src/mainboard/lenovo/s230u/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 32:
# ?
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 33: P
device pci 01.0 off end # PCIe Bridge for discrete graphics ...
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 34: d I
#
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 56: on end USB 3.0 Controller : device pci 16.0 off end Management Engine Interface 1 : device pci 16.1 off end Management Engine Interface 2 : device pci 16.2 off end Management Engine IDE-R : device pci 16.3 off end Management Engine KT : device pci 19.0 off end Intel Gigabit Ethernet : device pci 1a.0 on end USB2 EHCI #2 : device pci 1b.0 on end High Definition Audio Audio controller : device pci 1c.0 on end PCIe Port #1 : device pci 1c.1 on end PCIe Port #2 : device pci 1c.2 off end PCIe Port #3 : device pci 1c.3 on end PCIe Port #4 : device pci 1c.4 off end PCIe Port #5 : device pci 1c.5 off end PCIe Port #6 : device pci 1c.6 off end PCIe Port #7 : device pci 1c.7 off end PCIe Port #8 : device pci 1d.0 on end USB2 EHCI #1 : device pci 1e.0 off end PC
missing '#'
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 79:
# ?
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 82: n end : device i2c 55 on end : device i2c 56 on end : device i2c 57 on end : device i2c 5c on end : device i2c 5d on end : device i2c 5e on end : device i2c 5f on e
#
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 92:
# ?
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 93:
# ?
Done