Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34540 )
Change subject: src/mainboard: Add PCI device for IUO1 and IOU2 to devicetree
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG@9
PS1, Line 9: With commit 8950cfb66f8f1fd4b047fbef2347134be0aeacec
: (soc/intel: Use config_of()) a new function was introduced to get the
: pointer to the devicetree-config for a given device.
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG@17
PS1, Line 17: NULL-pointer
I’d spell it without -.
Done
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG@25
PS1, Line 25: derefferenced
dereferenced
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00a2e7ac14cf006718de55aa7a843442892d6280
Gerrit-Change-Number: 34540
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 24 Jul 2019 14:03:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment