Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46060 )
Change subject: rules.h: change verstage name if it starts before bootblock
......................................................................
Patch Set 2:
Patch Set 1:
Isn't it easier to just change ENV_STRING in <rules.h> for this case? It is only used to print banners like this.
I would suggest renaming the verstage string in this case (i.e. verstage-before-bootblock or something) because that's really the odd one out, and then adding that to the banner regex list in CBMEM with higher priority than bootblock.
I agree, thought I had to avoid changes in host utility but I was wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46060
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica38f6bfeb05605caadac208e790fd072b352732
Gerrit-Change-Number: 46060
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 07 Oct 2020 03:36:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment