Attention is currently required from: Paul Menzel, Felix Held. Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49112/comment/61d54031_dcd2db76 PS2, Line 7: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c
Please use the prefix: […]
Ack
https://review.coreboot.org/c/coreboot/+/49112/comment/52830de5_f79355bd PS2, Line 9: + {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART
This is in the code, but maybe document, what datasheet you used.
Ack
https://review.coreboot.org/c/coreboot/+/49112/comment/98a7e823_c9848935 PS2, Line 12: Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f
Please move this block to the end, and only use Change-Id once.
Ack
https://review.coreboot.org/c/coreboot/+/49112/comment/9bd1863a_f8c1fe59 PS2, Line 18: root@clay-MS-7C37:/home/clay/coreboot/util/superiotool#
This line can be removed.
Ack
Paul, I thought these four points were already acknowledged and fixed, but I guess it was only a draft. Sorry. Let me know if I need to make any other changes.
Patchset:
PS6: I thought I had these taken care of but I didn't sent the reply as it was still a draft. Sorry. Let me know if there is anything else I need to do.