Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44480 )
Change subject: mb/google/zork: Switch zork to use spd_tools
......................................................................
Patch Set 19: Code-Review+1
Patch Set 19:
Patch Set 16:
Patch Set 16:
I fixed up the Makefiles so they didn't have the MEMORY_TYPE in it anymore. I also removed all the now unused files.
+1 to removing the unused files.
What's the harm in leaving MEMORY_TYPE? The tool will put this back every time we run it.
That is removed from the tool. MEMORY_TYPE is no long being emitted. I ran the scripts to get the real output of the final form of the tool.
Oh, I didn't see that change. SG.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0553858f83d3d1e90cf35bece108768f004a29a5
Gerrit-Change-Number: 44480
Gerrit-PatchSet: 19
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 28 Aug 2020 15:41:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment