Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45181 )
Change subject: security/intel/stm: Fix size_t printf format error ......................................................................
Patch Set 3:
(3 comments)
Patch Set 3:
I though, Elyes would comment, but I think this fix is incorrect, and also has nothing to do with the platform but the build environment.
There is a dedicated length modifier for `size_t`. From `man 3 printf`:
z A following integer conversion corresponds to a size_t or ssize_t argument, or a following n conversion corresponds to a pointer to a size_t argument.
If I am right, please revert, or fix it correctly.
This patch does fix a build environment issue and I will submit a replacement patch that correctly addresses the issue.
https://review.coreboot.org/c/coreboot/+/45181/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45181/3//COMMIT_MSG@14 PS3, Line 14: unsigned int
in the code it is cast to a signed integer
Thanks for the catch, I will fix this in the upcoming update.
https://review.coreboot.org/c/coreboot/+/45181/3/src/security/intel/stm/SmmS... File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/c/coreboot/+/45181/3/src/security/intel/stm/SmmS... PS3, Line 480: lx
this should be zx
Thanks for showing me this. I will use it in the upcoming replacement patch
https://review.coreboot.org/c/coreboot/+/45181/3/src/security/intel/stm/SmmS... PS3, Line 480: int
this is a signed type, not an unsigned like size_t is
Cast will be removed in the replacement patch.