Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48479 )
Change subject: mb/google/guybrush: Add new mainboard ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... File src/mainboard/google/guybrush/board_info.txt:
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... PS7, Line 6: n
martinroth@ This is how Zork is set up, do you know why? I am not familiar with what this flag does.
This is likely due to flashrom searching for MB/Part# in the .id section at the end of the image. See cb_check_image() at the top of flashrom's cbtable.c. Clearly flashrom runs successfully on picasso-based designs and will with cezanne too. I don't know enough to say where there may be a problem, e.g. I'm not sure if the flashrom used in Chromebooks has been built to ignore the ID check.
IMO, I would leave line 6 as-is.