Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41081 )
Change subject: soc/intel/cannonlake: Add VrPowerDeliveryDesign to chip options ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41081/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41081/1//COMMIT_MSG@9 PS1, Line 9: Cannonlake
Cannon Lake
Ack
https://review.coreboot.org/c/coreboot/+/41081/1//COMMIT_MSG@9 PS1, Line 9: VrPowerDeliveryDesign
the UPD VrPowerDeliveryDesign
Ack
https://review.coreboot.org/c/coreboot/+/41081/1//COMMIT_MSG@12 PS1, Line 12:
As the code is shared with Comet Lake, only add it for Cannon Lake.
Ack
https://review.coreboot.org/c/coreboot/+/41081/1/src/soc/intel/cannonlake/ch... File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/41081/1/src/soc/intel/cannonlake/ch... PS1, Line 417: #if !CONFIG(SOC_INTEL_COMETLAKE)
Why not positive list? […]
I felt like this is the general rule in cannonlakefolder - to exclude COMETLAKE instead of including CANNONLAKE. in soc/cannonlake/fsp_params and soc/cannonlake/romstage/fsp_params you can find the same things - so I adopted it from there.