Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34484 )
Change subject: mb/google/hatch: Initialize SSD GPIOs in bootblock
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34484/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34484/1//COMMIT_MSG@16
PS1, Line 16: Run faft_bios
Not completely resolved. But I do believe that these are required. […]
Let's wait to root cause the issue to submit this change to ToT. It would be good to identify the actual behavior so that it helps more than just Hatch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cf09c26d77d890f5d0490709504e9edf485a93f
Gerrit-Change-Number: 34484
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 22 Jul 2019 18:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment