Attention is currently required from: Paul Menzel, Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64024 )
Change subject: drivers/phy/m88e1512: Add new driver for Marvell PHY 88E1512
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/64024/comment/17e62108_f80c6a2a
PS1, Line 124: .ops_pci = &pci_dev_ops_pci,
Should this be a separate patch, or at least mentioned in the commit message?
Is mentioned in the commit message:
"To be able to use the driver, it is necessary to activate
the scan bus operation in the corresponding SOC TSN GbE driver."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabe1aef2217dfaee4b5a4bd83782ab588d4be642
Gerrit-Change-Number: 64024
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Comment-Date: Tue, 03 May 2022 09:09:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment