Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44265
to review the following change.
Change subject: ec/google/chromeec: Add dptc interface support ......................................................................
ec/google/chromeec: Add dptc interface support
add the dptc interface support when system in tablet mode
BUG=b:157943445 BRANCH=none TEST=Build. check the setting changed.
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: I2be7942132cea474237f531021ad4fd9856b5050 --- M src/ec/google/chromeec/acpi/ec.asl M src/mainboard/google/zork/dsdt.asl M src/soc/amd/picasso/acpi/soc.asl 3 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/44265/1
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index f8d4bdf..4038a9a 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -10,7 +10,9 @@ #ifdef DPTF_ENABLE_CHARGER External (_SB.DPTF.TCHG, DeviceObj) #endif - +#ifdef DPTC_ENABLE +External(_SB.DPTC, MethodObj) +#endif
Device (EC0) { @@ -380,6 +382,9 @@ #ifdef EC_ENABLE_TBMC_DEVICE Notify (TBMC, 0x80) #endif +#ifdef DPTC_ENABLE + _SB.DPTC() +#endif }
/* diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index 2dc456d..b3e5f1b 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -34,9 +34,9 @@ Scope(_SB) { /* Start _SB scope */ /* global utility methods expected within the _SB scope */ #include <arch/x86/acpi/globutil.asl> - +#ifdef DPTC_ENABLE #include <variant/acpi/dptc.asl> - +#endif /* Describe the SOC */ #include <soc.asl>
diff --git a/src/soc/amd/picasso/acpi/soc.asl b/src/soc/amd/picasso/acpi/soc.asl index 909b985..a0a05fa 100644 --- a/src/soc/amd/picasso/acpi/soc.asl +++ b/src/soc/amd/picasso/acpi/soc.asl @@ -17,7 +17,9 @@ /* Describe the devices in the Southbridge */ #include "sb_fch.asl"
+#ifdef DPTC_ENABLE #include "dptc.asl" +#endif
/* Add GPIO library */ #include <soc/amd/common/acpi/gpio_bank_lib.asl>