Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Michał Żygowski, Werner Zeh.
Matt DeVillier has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/87050?usp=email )
Change subject: soc/intel/elkhartlake/pmc,gpio: Fix PMC GPE GPIO routes
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87050/comment/b04eb0cd_b9badfe5?usp... :
PS1, Line 7: elkahrtalake
elkhartlake
Done
https://review.coreboot.org/c/coreboot/+/87050/comment/933e1c7b_52d8d6e8?usp... :
PS1, Line 10: R&DC
R&DC is not necessary. The document title and number is the reference.
Done
https://review.coreboot.org/c/coreboot/+/87050/comment/f50de797_ca698e46?usp... :
PS1, Line 13: non-existent GPIO groups
I mean, GPP_S exists, but there is no value for it in the PMC and GPIO GPE DW registers. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87050?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I910f3c4c0d31b8d24b83cd2c3a28688b898b5d9f
Gerrit-Change-Number: 87050
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 09 Apr 2025 17:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com