Attention is currently required from: Arthur Heymans, Nico Huber, Maulik V Vaghela, Sugnan Prabhu S, Sridhar Siricilla, Subrata Banik, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59124 )
Change subject: soc/intel/common: Add CPU related APIs ......................................................................
Patch Set 7:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59124/comment/e9bbdf03_68f4ffd4 PS7, Line 13: cpu_get_cpu_typ `cpu_get_cpu_type`
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/59124/comment/ee4c34f2_3b10b6f0 PS7, Line 34: #define CPUID_PROCESSOR_FREQUENCY 0x16 : : #define CPUID_HYBRID_INFORMATION 0x1a : : /* Structured Extended Feature Flags */ : #define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7 : #define HYBRID_FEATURE BIT(15) please use tabs for indentation, and also align the right sides
https://review.coreboot.org/c/coreboot/+/59124/comment/9bee3698_b59494cb PS7, Line 199: cpu CPU
https://review.coreboot.org/c/coreboot/+/59124/comment/aa96385a_845c17a3 PS7, Line 199: cpu CPU
https://review.coreboot.org/c/coreboot/+/59124/comment/1d1a1d2f_4876538e PS7, Line 212: nit: extra space
https://review.coreboot.org/c/coreboot/+/59124/comment/3c9e2b18_fa8b420a PS7, Line 220: core_type What are the possible return values?
https://review.coreboot.org/c/coreboot/+/59124/comment/97aa7a5a_7d6bbd87 PS7, Line 224: cpu_get_bus_frequency What unit is this in? MHz?