Hello build bot (Jenkins), Martin Roth, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47769
to look at the new patch set (#3).
Change subject: util/amdfwtool: Fix EFS generation polarity ......................................................................
util/amdfwtool: Fix EFS generation polarity
The DWORD used to indicate the Embedded Firmware Structure's generation uses 1 to indicate a first-gen structure, e.g. a SPI device's erased value of 0xffffffff. A 0 in bit 0 is how Client PSPs will interpret the structure as designed for second-gen.
This change and the original addition should have no effects on any current products as none interpret offset 0x24.
BUG=b:158755102 TEST=inspect EFS in coreboot.rom
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: If391f356a1811ed04acdfe9ab9de2e146f6ef5fd --- M util/amdfwtool/amdfwtool.c 1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/47769/3