Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g...
File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g...
PS3, Line 33: 1
No, this is the physical dies per package. So, it has to be 1. […]
Done
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g...
PS3, Line 45: 2
Same as above: […]
Thanks for the explanation. Is diesPerPackage only used to determine total size?
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g...
PS3, Line 112: }
I already did that last night here: https://review.coreboot. […]
You rock !
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e2f98fc9c1c8a7f73c9a1bfab22c996de222a32
Gerrit-Change-Number: 41874
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jun 2020 18:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment