[coreboot-gerrit] [M] Change in coreboot[master]: drivers/uart: Add ACPI SPCR table generation

[Arthur Heymans (Code Review)]

Attention is currently required from: Martin L Roth.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49317?usp=email )

Change subject: drivers/uart: Add ACPI SPCR table generation
......................................................................

Patch Set 4:

(1 comment)

File src/drivers/uart/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/49317/comment/cc509645_1a870e09 :
PS4, Line 264: 		return current;
> So we filled in the entire SPCR inside ACPI CBMEM region, but decide here to abandon it? There's no real harm, but I feel it would be cleaner to abandon early..
>
> If I ananlyzed correctly that dev_update_spcr() is no-op in this commit, and update_spcr_data() is the only place setting spcr>base_address.addrl, seems to me the entire uart_acpi_write_spcr() call should be conditional on CONSOLE_SERIAL.
>
> I don't see what prevents creation of multiple SPCR entries in the case of multiple UARTs. All would have same uart_platform_base(CONFIG_UART_FOR_CONSOLE)?

Linux only looks for the first SPCR table.