Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 152:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... PS149, Line 119: Divide
old syntax
The remainder is used below to create the serial number characters. See Angel's comment.
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... PS149, Line 141: If ((Arg1 & 0x02))
If (Arg1 & 0x02)
Done
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... PS149, Line 119: If (((Arg0 == 0x03) && (Arg1 == 1)))
If ((Arg0 == 0x03) && (Arg1 == 1))
Done
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... PS149, Line 14: If (((Arg0 == 0x03) || (Arg0 == 0x04)))
If ((Arg0 == 0x03) || (Arg0 == 0x04))
Done
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/acpi/thermal.asl:
https://review.coreboot.org/c/coreboot/+/35523/149/src/mainboard/acer/aspire... PS149, Line 68: If (((Local0 >= 128) || (Local0 < 30)))
If ((Local0 >= 128) || (Local0 < 30))
Done