build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32240 )
Change subject: qcs405: clock: Update SPI API ......................................................................
Patch Set 1:
(18 comments)
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c File src/soc/qualcomm/qcs405/clock.c:
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@218 PS1, Line 218: if (blsp == 1) that open brace { should be on the previous line
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@220 PS1, Line 220: switch (qup) { switch and case should be at the same indent
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@222 PS1, Line 222: spi_clk = (struct qcs405_clock *)&gcc->blsp1_qup0_spi_clk; line over 80 characters
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@225 PS1, Line 225: spi_clk = (struct qcs405_clock *)&gcc->blsp1_qup1_spi_clk; line over 80 characters
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@228 PS1, Line 228: spi_clk = (struct qcs405_clock *)&gcc->blsp1_qup2_spi_clk; line over 80 characters
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@231 PS1, Line 231: spi_clk = (struct qcs405_clock *)&gcc->blsp1_qup3_spi_clk; line over 80 characters
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@234 PS1, Line 234: spi_clk = (struct qcs405_clock *)&gcc->blsp1_qup4_spi_clk; line over 80 characters
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@236 PS1, Line 236: } code indent should use tabs where possible
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@236 PS1, Line 236: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@237 PS1, Line 237: } code indent should use tabs where possible
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@237 PS1, Line 237: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@238 PS1, Line 238: else if (blsp == 2) else should follow close brace '}'
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@259 PS1, Line 259: if (blsp == 1) that open brace { should be on the previous line
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@261 PS1, Line 261: switch (qup) { switch and case should be at the same indent
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@279 PS1, Line 279: else if (blsp == 2) else should follow close brace '}'
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@287 PS1, Line 287: if (blsp == 1) that open brace { should be on the previous line
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@289 PS1, Line 289: switch (qup) { switch and case should be at the same indent
https://review.coreboot.org/#/c/32240/1/src/soc/qualcomm/qcs405/clock.c@308 PS1, Line 308: else if (blsp == 2) else should follow close brace '}'