build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 )
Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ......................................................................
Patch Set 3:
(25 comments)
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h File payloads/libpayload/include/stdlib.h:
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 51: void free(void *); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 52: void *malloc(size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 53: void *calloc(size_t,size_t); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 53: void *calloc(size_t,size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 53: void *calloc(size_t,size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 54: void *realloc(void*,size_t); space required after that ',' (ctx:OxV)
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 54: void *realloc(void*,size_t); function definition argument 'void*' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 54: void *realloc(void*,size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 55: void *memalign(size_t, size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 55: void *memalign(size_t, size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 56: void *dma_malloc(size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 57: void *dma_memalign(size_t, size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 57: void *dma_memalign(size_t, size_t); function definition argument 'size_t' should also have an identifier name
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 60: void * __p = p; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 60: void * __p = p; \ "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 71: size_t __s = s; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 84: size_t __n = n, __s = s; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 97: void *__p = p; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 98: size_t __s = s; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 111: size_t __a = a, __s = s; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 114: __FILE__, __func__, __LINE__);\ code indent should use tabs where possible
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 114: __FILE__, __func__, __LINE__);\ please, no space before tabs
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 124: size_t __s = s; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/include/stdlib.h... PS3, Line 137: size_t __a = a, __s = s; \ Statements should start on a tabstop
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/libc/malloc.c File payloads/libpayload/libc/malloc.c:
https://review.coreboot.org/#/c/14921/3/payloads/libpayload/libc/malloc.c@48... PS3, Line 483: printf(" found memalign region. %u free, %zu required\n", reg->free, (size + align - 1)/align); line over 80 characters