Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44948 )
Change subject: mb/google/volteer/variants/volteer: route GPP_F14 via APIC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44948/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/44948/1/src/mainboard/google/voltee... PS1, Line 128: PAD_CFG_GPI_APIC(GPP_F14, NONE, PLTRST, LEVEL, INVERT),
sx9310 is referencing this. […]
If there apic redirection entry is active low there's no need to invert because the inversion for the event will be filtered in the apic. It really depends on that.
I see in src/drivers/i2c/sx9310/sx9310.c:
-------if (config->irq_gpio.pin_count) ------->-------acpi_device_write_gpio(&config->irq_gpio); -------else ------->-------acpi_device_write_interrupt(&config->irq);
and in the devictree files:
$ git grep -A 3 -i sx9310 -- src/mainboard/google/volteer/ | grep irq | awk '{ print $NF }' | uniq -c 8 "ACPI_IRQ_LEVEL_LOW(GPP_F14_IRQ)"
So you not invert this and pass it through as level in the pad config.