Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 131: 0x090E000A putting the pad encoding here is pretty obscure. do we really need more than a boolean here? perhaps we can do the pad encoding (lookup) in fsp_params.c or something?
it would take a bit of digging to figure out the values for the rest of the IomTypeCPortPadCfg[...] should the need arise.
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 219: NF6 doesn't the FSP automatically do this when IomTypeCPortPadCfg[0], IomTypeCPortPadCfg[1] are non-zero?