Attention is currently required from: Jincheng Li, Shuo Liu.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81133?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/x86/include/arch: Add feature check macros ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Do you have code using them ? Adding declaration which are not used at all is a bit confusing.
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/81133/comment/26d407d1_d8b90918 : PS1, Line 54: #define CPUID_FEATURE_HTT (1 << 28) The typo fix should in a separate clean-up patch. Also I recommend use the BIT macro instead of the manual bit shift construction.