Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39638 )
Change subject: drivers/intel/gma: hook up GMA for Skylake+
......................................................................
Patch Set 5: Code-Review-1
Nico: Would you really prefer local variables in common to entries in the globalnvs OpRegion? Past platforms used the latter.
In any case, this presently redefines ACPI platforms on older platforms, so something will need correcting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c2f0e8fe1ef91334d494c8a8605dd46cda80e3d
Gerrit-Change-Number: 39638
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Mar 2020 21:47:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment