Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32661 )
Change subject: soc/amd/stoneyridge: Move sata to common ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/32661/4/src/soc/amd/common/block/include/amd... File src/soc/amd/common/block/include/amdblocks/sata.h:
https://review.coreboot.org/#/c/32661/4/src/soc/amd/common/block/include/amd... PS4, Line 17: __STON__AMDBLOCKS_SATA_H__EYRIDGE_CPU_H__ Why is this here?
https://review.coreboot.org/#/c/32661/4/src/soc/amd/common/block/sata/sata.c File src/soc/amd/common/block/sata/sata.c:
https://review.coreboot.org/#/c/32661/4/src/soc/amd/common/block/sata/sata.c... PS4, Line 24: sata_init Is sata_init() required at all? Can we instead set .init = soc_enable_sata_features and add a weak definition here which does nothing?
https://review.coreboot.org/#/c/32661/4/src/soc/amd/common/block/sata/sata.c... PS4, Line 29: static struct pci_operations lops_pci = { : /* .set_subsystem = pci_dev_set_subsystem, */ : }; Is this required at all?