Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43283 )
Change subject: src: Remove redundant use of ACPI offset(0) ......................................................................
Patch Set 4:
(10 comments)
I overlooked some things last time. I have some new suggestions see the comments below
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/compal/ene932/acpi/e... File src/ec/compal/ene932/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/compal/ene932/acpi/e... PS4, Line 19: , 1, // Reserved ; 00h.0 I think the leading comma is confusing (didn't notice before I am sorry)
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/quanta/it8518/acpi/e... File src/ec/quanta/it8518/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/quanta/it8518/acpi/e... PS4, Line 20: , I think the leading comma is confusing (didn't notice before I am sorry)
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/roda/it8518/acpi/ec.... File src/ec/roda/it8518/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/roda/it8518/acpi/ec.... PS4, Line 17: / I guess I was wrong here, now the comment doesn't really make sense any more
https://review.coreboot.org/c/coreboot/+/43283/4/src/mainboard/lenovo/s230u/... File src/mainboard/lenovo/s230u/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/mainboard/lenovo/s230u/... PS4, Line 15: , I think the leading comma is confusing (didn't notice before I am sorry)
https://review.coreboot.org/c/coreboot/+/43283/4/src/mainboard/lippert/front... File src/mainboard/lippert/frontrunner-af/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/mainboard/lippert/front... PS4, Line 138: , I think the leading comma is confusing (didn't notice before I am sorry)
https://review.coreboot.org/c/coreboot/+/43283/4/src/mainboard/lippert/touca... File src/mainboard/lippert/toucan-af/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/mainboard/lippert/touca... PS4, Line 138: , I think the leading comma is confusing (didn't notice before I am sorry)
https://review.coreboot.org/c/coreboot/+/43283/4/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/soc/intel/cannonlake/ac... PS4, Line 26: /* I guess the comment should be behind the entry here
https://review.coreboot.org/c/coreboot/+/43283/4/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb800/acpi/fch.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/southbridge/amd/cimx/sb... PS4, Line 216: /* I think the leading comma is confusing (didn't notice before I am sorry)
https://review.coreboot.org/c/coreboot/+/43283/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/acpi/ich9.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/southbridge/intel/i8280... PS4, Line 35: / Comment behind the entry?
https://review.coreboot.org/c/coreboot/+/43283/4/src/superio/fintek/f81803a/... File src/superio/fintek/f81803a/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/superio/fintek/f81803a/... PS4, Line 237: /*Control Reg 5 */ I think the leading comma is confusing (didn't notice before I am sorry)