[coreboot-gerrit] Change in coreboot[master]: mb/emulation/qemu-i440fx: Select IOAPIC

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55290 )

Change subject: mb/emulation/qemu-i440fx: Select IOAPIC
......................................................................

mb/emulation/qemu-i440fx: Select IOAPIC

For SMP operation IOAPIC needs to be configured.

For a build with MAX_CPUS=1 emulation might still decode
the IOAPIC MMIO window, it does not really matter to have
it always reserved.

Change-Id: Ia340fc418cd9ceda56a2a10972e130d9f289c589
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55290
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
Reviewed-by: Angel Pons 
---
M src/mainboard/emulation/qemu-i440fx/Kconfig
M src/southbridge/intel/i82371eb/isa.c
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig
index 1b9edf0..eb745e7 100644
--- a/src/mainboard/emulation/qemu-i440fx/Kconfig
+++ b/src/mainboard/emulation/qemu-i440fx/Kconfig
@@ -16,6 +16,7 @@
    select HAVE_ASAN_IN_ROMSTAGE
    select NO_SMM
    select BOOT_DEVICE_NOT_SPI_FLASH
+	select IOAPIC

config VBOOT
    select VBOOT_MUST_REQUEST_DISPLAY
diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c
index c2411f2b..5eb1a82 100644
--- a/src/southbridge/intel/i82371eb/isa.c
+++ b/src/southbridge/intel/i82371eb/isa.c
@@ -85,13 +85,11 @@
    res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED |
    	IORESOURCE_RESERVE;

-#if CONFIG(IOAPIC)
    res = new_resource(dev, 3); /* IOAPIC */
    res->base = IO_APIC_ADDR;
    res->size = 0x00001000;
    res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED |
    	IORESOURCE_RESERVE;
-#endif
 }

static const struct device_operations isa_ops = {

9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.