Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47990 )
Change subject: soc/intel/common/fast_spi: Add extended decode window support ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47990/8/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47990/8/src/soc/intel/common/block/... PS8, Line 269: fast_spi_get_ext_bios_window(&ext_bios_base, &ext_bios_size); : : /* Enable extended BIOS only if size of Bios region is greater than 16MiB */ : if (ext_bios_size == 0 || ext_bios_base == 0) : return; Actually, we will have to unconditionally configure the window here using the base provided by the SoC. This window base has to be a multiple of 32MiB and the size is fixed too. Even though the mmap boot device might decide to use a smaller portion of the window, the decoding can only be enabled for the entire window. I will push an update to this CL and also update the documentation.