Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38179 )
Change subject: drivers/pc80/rtc: Clean up some inlined functions
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38179/2/src/drivers/pc80/rtc/mc1468...
File src/drivers/pc80/rtc/mc146818rtc.c:
https://review.coreboot.org/c/coreboot/+/38179/2/src/drivers/pc80/rtc/mc1468...
PS2, Line 86: reg_d
Is this variable needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38179
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie73797b4e9a09605a0685f0b03cb85e9a3be93ad
Gerrit-Change-Number: 38179
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Jan 2020 00:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment