John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38165 )
Change subject: soc/intel/tigerlake: Enable VT-d and generate DMAR ACPI table
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38165/4/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/38165/4/src/soc/intel/tigerlake/inc...
PS4, Line 4: 2019
2019-2020. […]
done.
https://review.coreboot.org/c/coreboot/+/38165/4/src/soc/intel/tigerlake/inc...
PS4, Line 37: #define CAPID0_A 0xe4
: #define VTD_DISABLE (1 << 23)
can we move common defines to the common header?
done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib89d0835385487735c63062a084794d9da19605e
Gerrit-Change-Number: 38165
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Fri, 31 Jan 2020 01:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-MessageType: comment